re-add the call to super_statement in EraseRegions#42931
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 28, 2017
Merged
re-add the call to super_statement in EraseRegions#42931bors merged 1 commit intorust-lang:masterfrom
super_statement in EraseRegions#42931bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
|
@bors r+ |
Collaborator
|
📌 Commit dded9e9 has been approved by |
Contributor
Author
|
@bors p=100 This unbreaks the nightly |
Collaborator
|
⌛ Testing commit dded9e91ee8d9b73442b64d4c0a2dab06969ac75 with merge c2b9827c84175162f9d65b01857c380b5f87a63d... |
Collaborator
|
💔 Test failed - status-travis |
Member
|
@bors retry |
Collaborator
|
⌛ Testing commit dded9e91ee8d9b73442b64d4c0a2dab06969ac75 with merge fbb85a9948e8757a3a57b67358247674d78cf9ba... |
Collaborator
|
💔 Test failed - status-travis |
Member
|
The move gathering code is sensitive to type-equality - that is rather un-robust and I plan to fix it eventually, but that's a more invasive change. And we want to fix the visitor anyway. Fixes rust-lang#42903.
dded9e9 to
71abfa7
Compare
Contributor
Author
|
@bors r=eddyb |
Collaborator
|
📌 Commit 71abfa7 has been approved by |
Collaborator
Contributor
|
@arielb1 thanks for the quick fix. Super embarrassing oversight on my part. :( |
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The move gathering code is sensitive to type-equality - that is rather
un-robust and I plan to fix it eventually, but that's a more invasive
change. And we want to fix the visitor anyway.
Fixes #42903.
r? @eddyb