Revert PR #93718 (use of #[used(linker)]) due to breakage on multiple platforms.#99674
Closed
thomcc wants to merge 1 commit intorust-lang:masterfrom
Closed
Revert PR #93718 (use of #[used(linker)]) due to breakage on multiple platforms.#99674thomcc wants to merge 1 commit intorust-lang:masterfrom
#[used(linker)]) due to breakage on multiple platforms.#99674thomcc wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Don't overwrite CodegenFnAttrs when adding used compiler/linker Pointed out by `@tmiasko` in rust-lang#93718 (comment). Probably a better fix than rust-lang#99674 for rust-lang#99596, assuming it does fix the latter. I don't have the ability to write a regression test for this at the moment, and am quite surprised this didn't cause other failures. The old code is clearly wrong though, but I'm not picky as to which of these is better to go with.
Member
|
We may want to see if #99676 fixes the reported issues before merging this revert. |
Collaborator
|
☔ The latest upstream changes (presumably #99676) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
It seems like the other PR has fixed the issues. I'm going to close it for now, but can reopen/rebase it if it turns out to be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99596, see it for background.
I'm not sure why that issue happens (especially given that it shouldn't change anything on ELF platforms), but don't have time to investigate deeply. The breakage sounds very bad, so this commits reverts the changes in the meantime.