fix: fix file handle leaks and add some attempt at a test for the fix#1313
Merged
simonw merged 1 commit intosimonw:mainfrom Dec 11, 2025
Merged
fix: fix file handle leaks and add some attempt at a test for the fix#1313simonw merged 1 commit intosimonw:mainfrom
simonw merged 1 commit intosimonw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See for details:
This small PR attempts to fix leaks in code that is in the library.
I didn't bother with the cli as it seemed less of an issue, but there are leaks in that code as well.