'husky install' fails if '.git' directory does not exists

[mondeja]

I have a postinstall script in a NPM package:

"postinstall": "is-ci || husky install",

If I download the repository using Github UI (Code -> Download ZIP), after extracting it, executing npm install raises Error: .git can't be found:

postinstall error

> simple-icons-font@4.9.0 postinstall /.../simple-icons-font-develop
> is-ci || husky install

/.../simple-icons-font-develop/node_modules/husky/lib/commands/install.js:20
        throw new Error(".git can't be found");
        ^

Error: .git can't be found
    at Object.install (/.../simple-icons-font-develop/node_modules/husky/lib/commands/install.js:20:15)
    at Object.<anonymous> (/.../simple-icons-font-develop/node_modules/husky/lib/bin.js:43:19)

I can prevent the error doing something like this:

"postinstall": "node -e \"if(require('fs').existsSync('.git')){process.exit(1)}\" || is-ci || husky install",

But it seems a bit hacky. What would be the recommended way to solve this?

[typicode]

Hi @mondeja,

Thanks for the report. It's fixed in v5.0.9. If not in a git repo, Git will simply output a message and not fail.

[mondeja]

Thank you @typicode! 🙏

[gajus]

This is still an issue:

npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm ERR! code 1
npm ERR! path /Users/gajus/Documents/dev/gajus/roarr/node_modules/fast-printf
npm ERR! command failed
npm ERR! command sh -c husky install
npm ERR! /Users/gajus/Documents/dev/gajus/roarr/node_modules/husky/lib/commands/install.js:20
npm ERR!         throw new Error(".git can't be found");
npm ERR!         ^
npm ERR!
npm ERR! Error: .git can't be found
npm ERR!     at Object.install (/Users/gajus/Documents/dev/gajus/roarr/node_modules/husky/lib/commands/install.js:20:15)
npm ERR!     at Object.<anonymous> (/Users/gajus/Documents/dev/gajus/roarr/node_modules/husky/lib/bin.js:43:19)
npm ERR!     at Module._compile (node:internal/modules/cjs/loader:1102:14)
npm ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1131:10)
npm ERR!     at Module.load (node:internal/modules/cjs/loader:967:32)
npm ERR!     at Function.Module._load (node:internal/modules/cjs/loader:807:14)
npm ERR!     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
npm ERR!     at node:internal/main/run_main_module:17:47

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/gajus/.npm/_logs/2021-02-08T20_02_58_259Z-debug.log

https://github.com/gajus/fast-printf/blob/master/package.json#L32

[lc-leoniefarmer]

I'm running v5.0.9 and am getting this error :-(

throw new Error(".git can't be found");

[typicode]

Can't seem to reproduce, here's how I'm testing:

$ cd /tmp
$ mkdir foo && cd foo
$ npm init -y
$ npm install husky -D
$ npx husky install
husky - not a Git repository, skipping hooks installation

Is your package.json in a nested directory compared to .git? If that's the case, see https://typicode.github.io/husky/#/?id=custom-directory

Otherwise could you provide minimal steps for me to reproduce (or a repo)?

[lc-leoniefarmer]

We get the issue when we use a repo as a dependency. e.g. in package.json:
"ourapp": "git+ssh://git@github.com/myproject/ourapp.git#v9.1.3",

For more information on how this works see: https://docs.npmjs.com/cli/v6/commands/npm-install

We have followed the advice to use pinst to work around this issue:

"scripts": {
    "postinstall": "husky install",
    "prepublishOnly": "pinst --disable",
    "postpublish": "pinst --enable"
  }

But get the error when installing the updated version:

throw new Error(".git can't be found");

[typicode]

Thanks for the details. This is a bit of an edge case.

When you publish a package on npm, prepublishOnly ensures that postinstall is deactivated by renaming it to _postinstall. This way, when someone install this package, husky won't install hooks.

Here, this step is not run and when npm install git+ssh://git@github.com/myproject/ourapp.git#v9.1.3 runs, postinstall will execute.

AFAIK I don't think there's a way to detect that.

Personally, I would remove postinstall, prepublishOnly, postpublish and add a mention in the README telling people to manually run npx --no-install husky install if they want to enable Git hooks.

[IevgeniiK-AVISPL]

Having the same issue...

Trying to install via npm swagger-ui-react (swagger link) BUT im getting this error..
- swagger-client@3.13.0 postinstall /front/node_modules/swagger-client
- husky install
throw new Error(".git can't be found");

as a devDependency husky installed..
"husky": "^5.0.9",

if there is an option to fix that?

[typicode]

@IevgeniiK-AVISPL seems to be fixed by swagger-client@3.13.1

[LinnJS]

I am having this same issue when trying to install husky on a repo where I have multiple projects and the .git file is up a directory. Are there configuration options for this use case? I have two projects with node modules nested inside one git repo for the sanity CMS and the Gatsby FE.