numfmt: fix empty delimiter and whitespace handling#10350
Merged
sylvestre merged 3 commits intouutils:mainfrom Feb 15, 2026
Merged
numfmt: fix empty delimiter and whitespace handling#10350sylvestre merged 3 commits intouutils:mainfrom
sylvestre merged 3 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
|
needs a rebase, sorry |
41bf68d to
948a2cd
Compare
|
GNU testsuite comparison: |
948a2cd to
dc7943f
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theres still around 61 failing tests in numfmt, around 14 of them relate to how empty delimiters and whitespace is handled. This PR adds a bunch of integration tests based on the GNU integration tests and adds the logic that decides whether the number of whitespaces is valid or invalid.
The high level gist is that the amount of whitespaces defaults to 1 but is should be equal to the length of the delimiter option if it is explicitly provided.
These are all of the gnu test cases fixed by this pr: