fold: refactor compute_col_count and add character mode tests#10533
Merged
sylvestre merged 1 commit intouutils:mainfrom Feb 4, 2026
Merged
fold: refactor compute_col_count and add character mode tests#10533sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
aaron-ang
pushed a commit
to aaron-ang/coreutils
that referenced
this pull request
Feb 4, 2026
…e-col-count fold: refactor compute_col_count and add character mode tests
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reviewing and merging #10530 I came to the realization that now the logic for characters matches the logic for Columns. I also afterwards installed the extension for codecov and saw that some of the of the match cases were missing code coverage.
From the Fuzzing I knew that the PR logic was sound, it just would be missing regression checks for future changes. Made this follow up PR to make the matching less verbose and add test cases for each of the match cases and tested it with gnu 9.9.