Skip to content

tsort: Use rustc-hash#10680

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:ts3
Feb 3, 2026
Merged

tsort: Use rustc-hash#10680
sylvestre merged 1 commit intouutils:mainfrom
oech3:ts3

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Feb 3, 2026

3% perf gain?
Since Fnv is already used at ls (assuming ls is not used for unreliable files) , no reason to avoid non-crypto hash func.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 3, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 16.74%

Comparing oech3:ts3 (cd2a8e2) with main (b311460)

Summary

⚡ 4 improved benchmarks
✅ 280 untouched benchmarks
⏩ 38 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation tsort_complex_dag[50000] 85.4 ms 73.1 ms +16.74%
Simulation tsort_tree_dag[(10, 3)] 34.2 ms 29.4 ms +16.15%
Simulation tsort_linear_chain[1000000] 1.6 s 1.4 s +10.48%
Simulation tsort_wide_dag[100000] 130 ms 116.5 ms +11.61%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 marked this pull request as ready for review February 3, 2026 13:45
@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Feb 3, 2026

@oech3 Have you tried foldhash yet?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Feb 3, 2026

No. But I saw xxhash3 was bad.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@oech3 oech3 requested a review from sylvestre February 3, 2026 17:55
@sylvestre sylvestre merged commit d41ed38 into uutils:main Feb 3, 2026
203 of 221 checks passed
@oech3 oech3 deleted the ts3 branch February 3, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants