Skip to content

sort: remove redundant if#10716

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:sortif
Feb 4, 2026
Merged

sort: remove redundant if#10716
sylvestre merged 1 commit intouutils:mainfrom
oech3:sortif

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Feb 4, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

if matches.get_flag(options::modes::RANDOM) {
mode_flags.random = true;
}
let mut mode_flags = ModeFlags {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, well done :)

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Feb 4, 2026

It would be even better if we could avoid accessing private fields outside of ModeFlags implementation.

@oech3 oech3 marked this pull request as ready for review February 4, 2026 16:11
@sylvestre sylvestre merged commit c7ad6ff into uutils:main Feb 4, 2026
194 of 198 checks passed
@oech3 oech3 deleted the sortif branch February 4, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants