chore: clippy::unnecessary_wraps#10722
Merged
sylvestre merged 2 commits intouutils:mainfrom Feb 5, 2026
Merged
Conversation
nyurik
force-pushed
the
unnecessary_wraps
branch
2 times, most recently
from
e1af275 to
2e6990e
Compare
|
GNU testsuite comparison: |
* [`clippy::unnecessary_wraps`](https://rust-lang.github.io/rust-clippy/master/index.html?search=wildcard_imports#wildcard_imports) Returning Option or Result when they are not needed leads to incorrect assumptions and extra error code where none is needed. This PR removed a few cases like that.
nyurik
force-pushed
the
unnecessary_wraps
branch
from
2e6990e to
7b78134
Compare
|
GNU testsuite comparison: |
xtqqczze
reviewed
Feb 5, 2026
src/uu/du/src/du.rs
Outdated
| } | ||
|
|
||
| #[cfg(not(windows))] | ||
| #[expect(clippy::unnecessary_wraps)] // To match all platforms |
Contributor
There was a problem hiding this comment.
could use reason attribute, like:
#[expect(clippy::some_lint, reason = "False positive rust-lang/rust-clippy#1002020")]
Contributor
Author
There was a problem hiding this comment.
thx, good idea, fixed
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clippy::unnecessary_wrapsReturning Option or Result when they are not needed leads to incorrect assumptions and extra error code where none is needed. This PR removed a few cases like that.