Skip to content

sort: remove reserve which is difficult to understand#11040

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:sort-unres
Feb 21, 2026
Merged

sort: remove reserve which is difficult to understand#11040
sylvestre merged 1 commit intouutils:mainfrom
oech3:sort-unres

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Feb 20, 2026

This might still needed for custom allocator. But it seems not needed currently.

@oech3 oech3 changed the title Sort unres sort: remove reserve hack which is difficult to understand Feb 20, 2026
@oech3 oech3 force-pushed the sort-unres branch 2 times, most recently from 19e972a to e1c6ba5 Compare February 20, 2026 20:57
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Feb 20, 2026

sort_long_line[16000] 502.3 -> 500.6 µs
sort_long_line[16000] 126.9 -> 126.7 KB
sort_numeric_utf8_locale 20 -> 19.9 ms

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/date/resolution. tests/date/resolution is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/date/date-locale-hour is no longer failing!

@oech3 oech3 changed the title sort: remove reserve hack which is difficult to understand sort: remove reserve which is difficult to understand Feb 20, 2026
@oech3 oech3 marked this pull request as ready for review February 21, 2026 09:39
@sylvestre sylvestre merged commit 4438adf into uutils:main Feb 21, 2026
154 of 157 checks passed
@oech3 oech3 deleted the sort-unres branch February 21, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants