fix(numfmt): format output on error messages#11179
Merged
cakebaker merged 2 commits intouutils:mainfrom Mar 4, 2026
Merged
Conversation
|
GNU testsuite comparison: |
cakebaker
reviewed
Mar 3, 2026
src/uu/numfmt/src/format.rs
Outdated
| pub(crate) fn escape_line(line: &[u8]) -> String { | ||
| line.iter() | ||
| .map(|&b| { | ||
| if b.is_ascii_graphic() || b.is_ascii_whitespace() { |
Contributor
There was a problem hiding this comment.
It's unfortunately more complex because line also can contain valid UTF-8 multi-byte characters:
$ printf "10\n\xFF🦀" | cargo run -q numfmt
10
numfmt: invalid number: '\377\360\237\246\200'
$ printf "10\n\xFF🦀" | numfmt
10
numfmt: invalid number: ‘\377🦀’
I don't know if you want to address it in this PR, otherwise a TODO would be helpful.
Contributor
Author
There was a problem hiding this comment.
ouch, will give it a shot
Merging this PR will not alter performance
Comparing 
Footnotes
|
|
GNU testsuite comparison: |
cakebaker
reviewed
Mar 4, 2026
| /// Used to safely format invalid input in error messages. | ||
| pub(crate) fn escape_line(line: &[u8]) -> String { | ||
| let mut result = String::new(); | ||
| for chunk in line.utf8_chunks() { |
Contributor
There was a problem hiding this comment.
Nice, I didn't know there is such a function in the std :)
Contributor
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11116