Skip to content

true, false: drop Vec for binary size and perf#11223

Merged
cakebaker merged 1 commit intouutils:mainfrom
oech3:true-iter
Mar 7, 2026
Merged

true, false: drop Vec for binary size and perf#11223
cakebaker merged 1 commit intouutils:mainfrom
oech3:true-iter

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 7, 2026

$ taskset -c 1 hyperfine -N --warmup 10000 ...
...
Summary
  true ran
    1.01 ± 0.19 times faster than true-main

about -0.2 kb

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 7, 2026

I guess CodSpeed does not catch perf gain since it does not catch cost of process generation.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2026

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@oech3 oech3 marked this pull request as ready for review March 7, 2026 09:53
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 7, 2026

Should we add bench for process generation instead of uumain()?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@cakebaker cakebaker merged commit 59aa4d7 into uutils:main Mar 7, 2026
159 of 160 checks passed
@oech3 oech3 deleted the true-iter branch March 7, 2026 15:07
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants