[V2] Color degredations

[mike-engel]

• I am on the latest Hyper.app version
• I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: macOS 10.13.0
• Hyper.app version: 2.0.4 & 1.4.8
• Link of a Gist with the contents of your .hyper.js: https://gist.github.com/mike-engel/0fcc34f787fa7875e91faf36ea19d67a
• Relevant information from devtools: N/A
• The issue is reproducible in vanilla Hyper.app: Yep. Moving my hyper.js config to another location and restarting also has bad color representations.

Issue

While moving to 2.0, I've noticed that colors are not behaving properly anymore. In programs like Vim the colors between 2.x and 1.x are vastly different. While debugging, I also noticed that the color representations between the two versions seem to be much different.

Referring to this gist and this script, you can see from my screenshots that there are some differences.

This may be an issue with xterm.js, so if it is, let me know and I'll move over there. Here's my vim config as well. It's important to note that that exact vim config looks ok on 1.x, but not ok on 2.x.

Please let me know if there's any info you need. If you have some general ideas on where to start, I can work on a PR. Thanks!

EDIT: It seems like xterm.js doesn't support truecolor, which may be part of the problem with the color script, but doesn't explain the vim differences.

Screenshots

Vim

Details

Color script

Details

2.x

1.x

[markozxuu]

@mike-engel Had not noticed that error, it could be due to xterm.js 🤔

I'll take a look at this problem.

[welnanick]

I have noticed this too.

I switched to a true-color vim theme in 1.x due to #155 , this does not work in 2.x
I tried switching back to my old theme and it also is not rendering properly in 2.x

I am using this hyper-theme to get the solarized color palette

[markozxuu]

@welnanick We are working to solve the problem of colors.

[darkdreamingdan]

My colours configuraion barely has any impact in Windows Bash. I can only seem to get the window background colour working - tried the solarized theme but it also doesn't seem to work.

It seems to always force the default bash colours.

[fsegouin]

I'm having the same issue with fish, some colors just don't work.

[mike-engel]

fwiw I'm using fish as well. Could be an issue with how fish represents colors

[welnanick]

I'm not using fish, and I am also having these issues, so unfortunately I don't think its related to fish :/

[Stanzilla]

xtermjs/xterm.js#484

[chabou]

To be clear, this issue is related to 256 colors not true color.
Color Script, that tests 256 colors must render same thing in 2.x than in 1.x

[chabou]

ok 3-byte color mode in script is 24-bits Truecolor. This is not supposed to work yet. So everything is ok with color script on Mac (in last canary with xterm3 too).

@mike-engel Can you try to reproduce your vim issue with our last canary? (with and without your hyper plugins)

[mike-engel]

@chabou It looks like the latest canary is much better, but for some reason my vim config is still using the incorrect colors. It could be my vim config, but it is curious how different it looks with the same config. The color test, however, looks much better 😄

Screenshots

Left: Hyper 1.4.8
Right: 2.0.0-canary.11

Vim

Details

Color test

Details

[chabou]

@mike-engel can you confirm me that running vim with your config in Terminal or iTerm looks like hyper v1.4.8?