Viomem - integration/build fixes.#1062
Merged
YanVugenfirer merged 1 commit intomasterfrom Mar 27, 2024
viomem
Merged
Conversation
changed deprecated function; fixed target names in project file; added hck-ci triggers. Signed-off-by: Marek Kedzierski <mkedzier@redhat.com> Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
YanVugenfirer
approved these changes
Mar 27, 2024
Collaborator
YanVugenfirer
left a comment
There was a problem hiding this comment.
- Feature negotiation must be reviewed again. Currently, the negotiated feature must be studied to understand the exact driver behavior
- Waiting for the command submission must be improved. Waiting for 1 second can fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.