Skip to content

docs: add ComponentPreview and Tailwind button demos#4

Merged
cwandev merged 15 commits intomainfrom
feature/docs-demo
Mar 3, 2026
Merged

docs: add ComponentPreview and Tailwind button demos#4
cwandev merged 15 commits intomainfrom
feature/docs-demo

Conversation

@cwandev
Copy link
Copy Markdown
Collaborator

@cwandev cwandev commented Feb 26, 2026

No description provided.

@cwandev cwandev requested a review from peoray February 26, 2026 09:31
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 26, 2026

Open in StackBlitz

pnpm add https://pkg.pr.new/vuepont/base-ui-vue@4

commit: 0c6db1c

@cwandev cwandev changed the title Feature/docs demo docs: add ComponentPreview and Tailwind button demos Feb 27, 2026
Copy link
Copy Markdown
Member

@peoray peoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the example for loading as a div removed, everything else looks good :)

Also, it seems we didn't do interactive rebasing here since we still have commits from the Button PR :( - can we do git rebase main, or is there no need?

For the part of the CSS Modules, since we don't have that, maybe we should probably rename it as CSS Only or something like that. What do you think?

For the demo part, I think it's better to have all the button demos inside a main Button folder. What do you think?

The section where you chose between tailwind and css modules does not seem to be focusable

@cwandev
Copy link
Copy Markdown
Collaborator Author

cwandev commented Mar 2, 2026

Good observations. I’ve added the “loading as a div” demo and renamed CSS Modules to CSS.

The PR has already been rebased, so you shouldn’t see any feature/button code in this PR. The reason you’re seeing those commit records is likely because I had to resolve a large number of conflicts during the rebase (after I created the docs-demo branch, feature/button changed significantly). Also, during merge commits, those commit messages can appear in the description section — you can manually remove the unnecessary ones there.

Regarding grouping all Button demos into a main Button folder, I suggest keeping the current flat structure for now. It aligns with the plugin parsing logic, keeps naming straightforward, and as more components are added, the prefix naming will naturally create grouping.

As for the focus issue — how did you test it? I checked your demo implementation, and the behavior appears the same on my end.

@peoray
Copy link
Copy Markdown
Member

peoray commented Mar 2, 2026

bettershot_1772420493245

I'm referring to the highlighted section @cwandev

@cwandev
Copy link
Copy Markdown
Collaborator Author

cwandev commented Mar 2, 2026

Got it. Here it uses a native select element. Maybe we can optimize this part once our select component is ready.

@cwandev cwandev merged commit 5624ab3 into main Mar 3, 2026
4 checks passed
@cwandev cwandev deleted the feature/docs-demo branch March 3, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants