docs: add ComponentPreview and Tailwind button demos#4
Conversation
commit: |
…nts and a direction provider
ea4e765 to
63d2f9d
Compare
There was a problem hiding this comment.
Aside from the example for loading as a div removed, everything else looks good :)
Also, it seems we didn't do interactive rebasing here since we still have commits from the Button PR :( - can we do git rebase main, or is there no need?
For the part of the CSS Modules, since we don't have that, maybe we should probably rename it as CSS Only or something like that. What do you think?
For the demo part, I think it's better to have all the button demos inside a main Button folder. What do you think?
The section where you chose between tailwind and css modules does not seem to be focusable
|
Good observations. I’ve added the “loading as a div” demo and renamed CSS Modules to CSS. The PR has already been rebased, so you shouldn’t see any Regarding grouping all Button demos into a main Button folder, I suggest keeping the current flat structure for now. It aligns with the plugin parsing logic, keeps naming straightforward, and as more components are added, the prefix naming will naturally create grouping. As for the focus issue — how did you test it? I checked your demo implementation, and the behavior appears the same on my end. |
I'm referring to the highlighted section @cwandev |
|
Got it. Here it uses a native select element. Maybe we can optimize this part once our select component is ready. |

No description provided.