Normalize port after updating scheme#328
Merged
domenic merged 2 commits intowhatwg:masterfrom Jun 30, 2017
Merged
Conversation
Member
|
Can do. |
Member
|
It seems like we should also file a bug against Edge. @TimothyGu are you up for that or shall I do it? |
rmisev
requested changes
Jun 28, 2017
| <li><p>Set <var>url</var>'s <a for=url>scheme</a> to <var>buffer</var>. | ||
|
|
||
| <li><p>If <var>url</var>'s <a for=url>port</a> is <var>url</var>'s <a for=url>scheme</a>'s | ||
| <a>default port</a>, then set <var>url</var>'s <a for=url>port</a> to null. |
Member
There was a problem hiding this comment.
This step is required for the protocol setter only, so it's better to place it after "4. If state override is given":
- Set url ’s scheme to buffer
- Set buffer to the empty string
- If state override is given, then:
- If url ’s port is url’s scheme’s default port , then set url’s port to null.
- Return.
Member
There was a problem hiding this comment.
Ah, yes, I think I agree with this.
And while we're in the area, is there a reason resetting buffer (3) is necessary before returning from a state override (4)?
Member
Author
There was a problem hiding this comment.
@rmisev It's sort of odd to see "Return" on its own line, which was why I refrained from this style initally, but that's fine with me.
@GPHemsley not particularly. Changed.
Member
Author
rmisev
approved these changes
Jun 29, 2017
Member
|
whatwg-url confirms spec and test change are in harmony and don't break anything else; merge time! |
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 30, 2017
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jun 30, 2017
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Jun 30, 2017
3 tasks
TimothyGu
added a commit
to nodejs/node
that referenced
this pull request
Jul 5, 2017
PR-URL: #13997 Refs: whatwg/url#328 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 11, 2017
PR-URL: #13997 Refs: whatwg/url#328 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 18, 2017
PR-URL: #13997 Refs: whatwg/url#328 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Fishrock123
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 19, 2017
PR-URL: #13997 Refs: whatwg/url#328 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #327.
Tests: web-platform-tests/wpt#6346
Preview | Diff