accept 1ms difference in filedates as equal on windows#3235
Merged
Daniel15 merged 1 commit intoyarnpkg:masterfrom Apr 24, 2017
Merged
accept 1ms difference in filedates as equal on windows#3235Daniel15 merged 1 commit intoyarnpkg:masterfrom
Daniel15 merged 1 commit intoyarnpkg:masterfrom
Conversation
a nodejs issue causes certain dates to be off by 1ms after calling utimes See: nodejs/node#12607
Member
|
Seems reasonable. Thanks! |
This was referenced Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an issue in node (nodejs/node#12607) with submillisecond truncation of file mtimes on Windows, which makes yarns fileDatesEqual test fail on any file that's affected by the bug. This causes many identical files to appear changed causing unneeded re-copying on every yarn command.
You can run this to reproduce the issue:
In my test projects this issue affects in the area of 10% of files, so in a project with 50000 files in node_modules you get roughly 5000 extra file copies per yarn command.