Repository navigation
Update dependency storybook to v8.6.19 [SECURITY] - #5657
Merged
Merged
Conversation
Latest k6 run output1Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
8.6.17→8.6.19Storybook manager bundle may expose environment variables during build
CVE-2025-68429 / GHSA-8452-54wp-rmv6
More information
Details
On December 11th, the Storybook team received a responsible disclosure alerting them to a potential vulnerability in certain built and published Storybooks.
The vulnerability is a bug in how Storybook handles environment variables defined in a
.envfile, which could, in specific circumstances, lead to those variables being unexpectedly bundled into the artifacts created by thestorybook buildcommand. When a built Storybook is published to the web, the bundle’s source is viewable, thus potentially exposing those variables to anyone with access. If those variables contained secrets, they should be considered compromised.Who is impacted?
For a project to be vulnerable to this issue, it must:
storybook builddirectly or indirectly) in a directory that contains a.envfile (including variants like.env.local).envfile contains sensitive secrets7.0.0or aboveStorybooks built without a
.envfile at build time are not affected, including common CI-based builds where secrets are provided via platform environment variables rather than.envfiles.Users' Storybook runtime environments (i.e.
storybook dev) are not affected. Deployed applications that share a repo with a project's Storybook are not affected.Storybook 6 and below are not affected.
Recommended actions
First, Storybook recommends that everyone audit for any sensitive secrets provided via
.envfiles and rotate those keys.Second, Storybook has released patched versions of all affected major Storybook versions that no longer have this vulnerability. Projects should upgrade their Storybook—on both local machines and CI environments—to one of these versions before publishing again.
10.1.10+9.1.17+8.6.15+7.6.21+Finally, some projects may have been relying on the undocumented behavior at the heart of this issue and will need to change how they reference environment variables after this update. If a project can no longer read necessary environmental variable values, it can either prefix the variables with
STORYBOOK_or use theenvproperty in Storybook’s configuration to manually specify values. In either case, do not include sensitive secrets as they will be included in the built bundle.Further information
Details of the vulnerability can be found on the Storybook announcement.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:L/A:LReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Storybook Dev Server is Vulnerable to WebSocket Hijacking
CVE-2026-27148 / GHSA-mjf5-7g4m-gx5w
More information
Details
Summary
The WebSocket functionality in Storybook's dev server, used to create and update stories, is vulnerable to WebSocket hijacking. This vulnerability only affects the Storybook dev server; production builds are not impacted.
Details
Exploitation requires a developer to visit a malicious website while their local Storybook dev server is running. Because the WebSocket connection does not validate the origin of incoming connections, a malicious site can silently send WebSocket messages to the local instance without any further user interaction.
If a Storybook dev server is intentionally exposed publicly (e.g. for design reviews or stakeholder demos) the risk is higher, as no malicious site visit is required. Any unauthenticated attacker can send WebSocket messages to it directly.
The vulnerability affects the WebSocket message handlers for creating and saving stories, which can be exploited via unauthorized WebSocket connections to achieve persistent XSS or Remote Code Execution (RCE).
Note: recent versions of Chrome have some protections against this, but Firefox does not.
Impact
This vulnerability can lead to supply chain compromise. Key risks include:
Affected versions
8.1 and above. While the exploitable functionality was introduced in 8.1, the patch has been applied to 7.x as a precautionary measure given the underlying WebSocket behaviour.
Recommended actions
Update to one of the patched versions:
7.6.23,8.6.17,9.1.19,10.2.10.Severity
CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:A/VC:H/VI:H/VA:H/SC:H/SI:H/SA:HReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Storybook: Missing origin validation in Storybook preview allows code injection from malicious websites
CVE-2026-114125 / GHSA-f2ph-cmg5-wxc8
More information
Details
Summary: A malicious website may be able to cause unauthorized file changes in a developer’s project while an affected Storybook development server is running. Under additional conditions, a changed file could be executed by a local runtime with the developer’s privileges. We are not aware of exploitation in the wild.
Who is impacted?
You are impacted if you run a Storybook dev server in the affected versions.
You are not impacted if:
Recent versions of Chrome and Firefox may ask for permission before a website can connect to a
localhostservice. This reduces the risk, but does not remove it. Do not grant this permission to websites you don’t trust.Recommended actions
Upgrade Storybook
Storybook has released patched versions of all affected major Storybook versions that fix all the vulnerabilities necessary for the worst-case scenario above to occur.
Upgrade to a patched version listed below before running
storybook devagain. If you cannot upgrade immediately, do not run an affected Storybook dev server until you can apply the fix.Review potentially breaking changes
Due to the exceptional nature of the reported vulnerabilities, the Storybook team has decided to change the default behavior of Storybook, including versions 8 and 9, for several network-related features that are not essential to most Storybook users' workflow. If your team relies on the affected features, we've added feature flags that can disable specific security updates to support your existing workflows.
Please carefully read the introduced flags and the consequences of using them.
Iframe embedding over the network is disabled by default
Storybook no longer allows the manager or preview to be embedded as an iframe on a website with a different host name. Built versions of Storybook are unaffected and can be freely embedded.
If you rely on embedding a Storybook dev server through a separate web app, run that separate app on
localhost. You may also use thesecurity.insecureRemoteIframeEmbedfeature flag to re-enable iframe embedding from any origin.The preview iframe rejects messages sent by an unknown host
Both the Storybook preview and manager now restrict the origin of iframes and parent windows that they can send messages to and receive messages from using the
postMessageAPI.By default, Storybook in dev mode only accepts communication with its own origin and other
localhostservices. Built Storybooks continue to accept communication from unknown origins.A Storybook addon or integration could hypothetically rely on
postMessageto update a live story's args. If you do that, reach out to the Storybook team to explore safer alternatives.Storybook composition also relies on
postMessage, so a composed Storybook on a different origin now fails to load unless it has been built. Thesecurity.insecureIframeMessagingfeature flag disables this protection, but we recommend you build composed Storybooks instead.The
highlightevent signature has changedStorybook’s own accessibility addon uses the
highlightevent to inject highlights into the preview, which a user can click. Clicking the highlight opens a menu with a link to a documentation page.The API for that event was too permissive and could be used to trigger arbitrary events, including events processed by the user’s dev server. We reworked the API to prevent abuse. Besides the accessibility addon, Chromatic's Visual Tests addon uses this API to link to documentation from highlighted ignored elements. Update the Visual Tests addon to version 5.5.1 or later to keep that link working. Because no other addons use this API as far as we know, we have not added a feature flag to restore the old API.
Disclosure timeline
On September 30th, the Storybook team received a responsible disclosure showing how a malicious website can embed a Storybook dev server's preview iframe and send events to the dev server on the developer's machine.
They combined this information with findings from an ongoing security audit to come up with a worst-case-scenario exploitation of the disclosed vulnerability, and the ones we independently discovered. They then worked to address all layers necessary for this worst-case scenario to happen. We have not received evidence of exploitation in real Storybook projects. The attack outlined in this advisory relies on correctly exploiting a sequence of many vulnerabilities, some of which were never disclosed to the Storybook team.
Worst-case attack scenario
An attacker-controlled website can interact with the preview of a running Storybook dev server. With user interaction, it may cause the dev server to make unauthorized changes to story files. If a malicious file is subsequently executed by a local runtime, the attack could lead to arbitrary code execution with the developer’s permissions.
Severity
CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:P/VC:H/VI:H/VA:H/SC:H/SI:H/SA:HReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
storybookjs/storybook (storybook)
v8.6.19Compare Source
8.6.19
v8.6.18Compare Source
8.6.18
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.