Repository navigation
fix(menu): menu can be encapsulated in a component - #28801
Merged
Merged
Conversation
liamdebeasi
changed the title
liamdebeasi
marked this pull request as ready for review
January 10, 2024 22:26
averyrousseau
approved these changes
Jan 15, 2024
This was referenced Jan 15, 2024
1 of 2 tasks
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-ionic-team__ionic-framework
that referenced
this pull request
Oct 21, 2026
…team#31586) Issue number: resolves ionic-team#30591 --------- ## What is the current behavior? Currently, a menu inside the split pane's main content, like an end menu on a page, is treated as a side pane, so it can't be opened while the split pane is visible. This broke in 8.0 when ionic-team#28801 changed the menu to look for any ancestor split pane, so that wrapped menus would work. ## What is the new behavior? A menu in the main content is now a regular menu and opens normally. Wrapped side menus still work, since the menu doesn't need to be a direct child of the split pane. ## Does this introduce a breaking change? - [ ] Yes - [X] No ## Other information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #16304, resolves #20681
What is the current behavior?
Split Pane assumes that Menu is a child of the Split Pane. This means that CSS selectors and JS queries only check for children instead of descendants. When a Menu is encapsulated in a component that component can itself show up as an element in the DOM depending on the environment. For example, both Angular and Web components show up as elements in the DOM. This causes the Menu to not work because it is no longer a child of the Split Pane.
What is the new behavior?
isPaneVisibledepending on if the split pane is visible or not.ionSplitPaneVisibleevent.::slottedwhich only targets children. The CSS was moved into the menu stylesheets. I consider the coupling here to be valuable as menu and split pane are often used together. We also already have style coupling between the two components, so this isn't anything new.Does this introduce a breaking change?
There are no known changes to the public API or public behavior. However, there are two risks here:
:host(.split-pane-visible) ::slotted(.split-pane-side)has a specificity of 0-1-1:host(.menu-page-visible.menu-pane-side)has a specificity of 0-1-0There shouldn't be any changes needed to developer code since the selectors are in the Shadow DOM and developer styles are in the Light DOM. However, we aren't able to anticipate every edge case so we'd like to place this in a major release just to be safe.
Other information
Dev build:
7.6.2-dev.11704922151.1fd3369f