Skip to content

agent_ui: Save configuration defaults after acceptance - #65849

Merged
benbrandt merged 1 commit into
mainfrom
benbrandt/acp-v2-config-defaults
Oct 20, 2026
Merged

benbrandt merged 1 commit into
mainfrom
benbrandt/acp-v2-config-defaults

Conversation

@benbrandt

@benbrandt benbrandt commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Save agent configuration defaults only after a successful request, using the value in the authoritative response rather than the requested value.

Cycling, boolean switches and picker confirmation previously wrote the requested default before sending the RPC. Rejection or a normalized response could therefore leave incorrect preferences for future sessions. All three controls now share one response-handling path:

  • No preference write while the request is pending or after rejection.
  • Save the response's current select/boolean value, not the requested value.
  • Do not overwrite preferences if the response removes the option, changes it to an unsupported kind, or does not offer the returned select value.

Release Notes:

  • acp: Fixed agent configuration defaults being saved before acceptance or ignoring the agent's returned value.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Oct 19, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Oct 19, 2026
@benbrandt
benbrandt marked this pull request as ready for review October 19, 2026 20:37
@benbrandt
benbrandt requested a review from bennetbo October 19, 2026 20:37
@benbrandt
benbrandt added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 1e99230 Oct 20, 2026
76 of 78 checks passed
@benbrandt
benbrandt deleted the benbrandt/acp-v2-config-defaults branch October 20, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants