Extract choice label formatting logic into reusable utility - #9028
Merged
Conversation
For example, a property choice with value "Mesh" and label "Mesh (works for Static only)" was displayed as "Mesh — Mesh (works for Static only)". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119ajoXq7k1UrzCzkuiCQYP
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119ajoXq7k1UrzCzkuiCQYP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the choice label formatting logic into a reusable utility function to reduce code duplication and improve maintainability.
Key Changes
ChoiceLabel.jsutility module withgetChoiceDisplayLabel()function that formats choice labels by:ChoiceLabel.spec.jscovering all formatting scenariosEventsBasedBehaviorOrObjectPropertiesEditor.jsto use the new utility functionPropertiesMapToSchema.jsto use the new utility functionImplementation Details
The
getChoiceDisplayLabel(value, label)function consolidates the previously duplicated logic that was inline in two different files. This improves code maintainability and ensures consistent behavior across the application when displaying choice options with optional translated labels.https://claude.ai/code/session_0119ajoXq7k1UrzCzkuiCQYP