Skip to content

Fix issue with group set only on second start - #990

Merged
lvca merged 1 commit into
ArcadeData:mainfrom
gramian:user
Mar 31, 2023
Merged

Fix issue with group set only on second start#990
lvca merged 1 commit into
ArcadeData:mainfrom
gramian:user

Conversation

@gramian

@gramian gramian commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

What does this PR do?

This change fixes a problem, that a group is only assigned on second start.

Related issues

#988

Additional Notes

The whole block from lines 530--562 can maybe refactored to reduce duplications.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca
lvca merged commit 9f2e800 into ArcadeData:main Mar 31, 2023
@lvca

lvca commented Mar 31, 2023

Copy link
Copy Markdown
Member

Awesome, thanks @gramian

@lvca lvca added this to the 23.3.1 milestone Mar 31, 2023
@lvca
lvca self-requested a review March 31, 2023 01:27
@lvca lvca added bug labels Mar 31, 2023
@gramian
gramian deleted the user branch March 31, 2023 19:47
tae898 pushed a commit to humemai/arcadedb-embedded-python that referenced this pull request Jun 28, 2026
mergify Bot added a commit that referenced this pull request Jul 29, 2026
…0.6 to 1.1.6 [skip ci]

Bumps [org.graalvm.buildtools:native-maven-plugin](https://github.com/graalvm/native-build-tools) from 0.10.6 to 1.1.6.
Release notes

*Sourced from [org.graalvm.buildtools:native-maven-plugin's releases](https://github.com/graalvm/native-build-tools/releases).*

> 1.1.6
> -----
>
> What's Changed
> --------------
>
> * Prefer GraalVM's Java when running with agent by [`@​vjovanov`](https://github.com/vjovanov) in [graalvm/native-build-tools#833](https://redirect.github.com/graalvm/native-build-tools/pull/833)
> * Make Maven agent execution ID configurable by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#933](https://redirect.github.com/graalvm/native-build-tools/pull/933)
> * Fix optional JUnit dependency resolution in Maven native tests by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#935](https://redirect.github.com/graalvm/native-build-tools/pull/935)
> * Log selected Maven metadata repository by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#936](https://redirect.github.com/graalvm/native-build-tools/pull/936)
> * Fix Maven test agent paths with spaces by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#934](https://redirect.github.com/graalvm/native-build-tools/pull/934)
> * Log Gradle agent output directory by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#937](https://redirect.github.com/graalvm/native-build-tools/pull/937)
> * Clarify JUnit launcher alignment for Maven native tests by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#938](https://redirect.github.com/graalvm/native-build-tools/pull/938)
> * Fix custom Gradle binary classpath wiring by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#939](https://redirect.github.com/graalvm/native-build-tools/pull/939)
> * Document Maven native test output directories by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#941](https://redirect.github.com/graalvm/native-build-tools/pull/941)
> * Fix Gradle agent toolchain detection by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#943](https://redirect.github.com/graalvm/native-build-tools/pull/943)
> * Fix Gradle metadata repository service scoping by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#942](https://redirect.github.com/graalvm/native-build-tools/pull/942)
> * Release 1.1.5 by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#972](https://redirect.github.com/graalvm/native-build-tools/pull/972)
> * Fix Groovy agent predicate closures by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#959](https://redirect.github.com/graalvm/native-build-tools/pull/959)
> * Make Maven skip apply to all goals by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#960](https://redirect.github.com/graalvm/native-build-tools/pull/960)
> * Document Maven resource configuration by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#965](https://redirect.github.com/graalvm/native-build-tools/pull/965)
> * Fix layered image configuration cache test by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#958](https://redirect.github.com/graalvm/native-build-tools/pull/958)
> * Respect build-tool console colors for Native Image output by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#961](https://redirect.github.com/graalvm/native-build-tools/pull/961)
> * Normalize platform-dependent resource and test paths by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#981](https://redirect.github.com/graalvm/native-build-tools/pull/981)
> * Bump version to 1.1.6-SNAPSHOT by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#990](https://redirect.github.com/graalvm/native-build-tools/pull/990)
> * Add class introduced in 6.1 by [`@​marcphilipp`](https://github.com/marcphilipp) in [graalvm/native-build-tools#867](https://redirect.github.com/graalvm/native-build-tools/pull/867)
> * Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0 in /samples/java-application-with-tests by [`@​dependabot`](https://github.com/dependabot)[bot] in [graalvm/native-build-tools#823](https://redirect.github.com/graalvm/native-build-tools/pull/823)
> * Fix order of access filter files by moving default to the start by [`@​ArloL`](https://github.com/ArloL) in [graalvm/native-build-tools#875](https://redirect.github.com/graalvm/native-build-tools/pull/875)
> * Allow the test classes directory to be configured for the NativeTestMojo by [`@​thegridman`](https://github.com/thegridman) in [graalvm/native-build-tools#757](https://redirect.github.com/graalvm/native-build-tools/pull/757)
> * Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0 in /samples/java-application-with-tests-in-src-main by [`@​dependabot`](https://github.com/dependabot)[bot] in [graalvm/native-build-tools#993](https://redirect.github.com/graalvm/native-build-tools/pull/993)
> * Preserve test runner argLine when configuring agent by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#992](https://redirect.github.com/graalvm/native-build-tools/pull/992)
> * Update reachability metadata to 1.0.7 by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#995](https://redirect.github.com/graalvm/native-build-tools/pull/995)
>
> New Contributors
> ----------------
>
> * [`@​ArloL`](https://github.com/ArloL) made their first contribution in [graalvm/native-build-tools#875](https://redirect.github.com/graalvm/native-build-tools/pull/875)
> * [`@​thegridman`](https://github.com/thegridman) made their first contribution in [graalvm/native-build-tools#757](https://redirect.github.com/graalvm/native-build-tools/pull/757)
>
> **Full Changelog**: <graalvm/native-build-tools@1.1.5...1.1.6>
>
> 1.1.5
> -----
>
> What's Changed
> --------------
>
> * Release 1.1.4 by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#963](https://redirect.github.com/graalvm/native-build-tools/pull/963)
> * Bump version to 1.1.5-SNAPSHOT by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#964](https://redirect.github.com/graalvm/native-build-tools/pull/964)
> * Fix Maven native test resource handling by [`@​alvarosanchez`](https://github.com/alvarosanchez) in [graalvm/native-build-tools#966](https://redirect.github.com/graalvm/native-build-tools/pull/966)
> * Support autodetected Jupiter extensions in native tests by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#919](https://redirect.github.com/graalvm/native-build-tools/pull/919)
> * Document Gradle tracing agent default mode by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#922](https://redirect.github.com/graalvm/native-build-tools/pull/922)
> * Fix Gradle nativeTest test resource detection by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#929](https://redirect.github.com/graalvm/native-build-tools/pull/929)
> * Document skipNativeBuildForPom for Maven aggregators by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#921](https://redirect.github.com/graalvm/native-build-tools/pull/921)
> * Fix custom native test classpath wiring by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#925](https://redirect.github.com/graalvm/native-build-tools/pull/925)
> * Make build infrastructure runnable on newer JDKs by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#928](https://redirect.github.com/graalvm/native-build-tools/pull/928)
> * Clarify buildArgs option entries by [`@​jormundur00`](https://github.com/jormundur00) in [graalvm/native-build-tools#931](https://redirect.github.com/graalvm/native-build-tools/pull/931)
> * Update reachability metadata to 1.0.6 by [`@​graalvmbot`](https://github.com/graalvmbot) in [graalvm/native-build-tools#971](https://redirect.github.com/graalvm/native-build-tools/pull/971)

... (truncated)


Commits

* [`7a6414c`](graalvm/native-build-tools@7a6414c) Release 1.1.6
* [`e95114f`](graalvm/native-build-tools@e95114f) Merge pull request [#995](https://redirect.github.com/graalvm/native-build-tools/issues/995) from graalvm/update-metadata-to-1.0.7
* [`b22ad4c`](graalvm/native-build-tools@b22ad4c) Update reachability metadata to 1.0.7
* [`bdcffba`](graalvm/native-build-tools@bdcffba) Preserve test runner argLine when configuring agent ([#992](https://redirect.github.com/graalvm/native-build-tools/issues/992))
* [`f817689`](graalvm/native-build-tools@f817689) Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0 in /samples/java-...
* [`4e52742`](graalvm/native-build-tools@4e52742) Allow the test classes directory to be configured for the NativeTestMojo ([#757](https://redirect.github.com/graalvm/native-build-tools/issues/757))
* [`2491c2c`](graalvm/native-build-tools@2491c2c) Fix order of access filter files by moving default to the start ([#875](https://redirect.github.com/graalvm/native-build-tools/issues/875))
* [`dd2072b`](graalvm/native-build-tools@dd2072b) Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0 in /samples/java-...
* [`e10adf0`](graalvm/native-build-tools@e10adf0) Add class introduced in 6.1
* [`53a3319`](graalvm/native-build-tools@53a3319) Bump version to 1.1.6-SNAPSHOT ([#990](https://redirect.github.com/graalvm/native-build-tools/issues/990))
* Additional commits viewable in [compare view](graalvm/native-build-tools@0.10.6...1.1.6)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.graalvm.buildtools:native-maven-plugin&package-manager=maven&previous-version=0.10.6&new-version=1.1.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants