Skip to content

WatchFaceDigital: Add weather display - #1856

Merged
FintasticMan merged 1 commit into
InfiniTimeOrg:mainfrom
vkareh:face-digital-weather
Jan 23, 2024
Merged

WatchFaceDigital: Add weather display#1856
FintasticMan merged 1 commit into
InfiniTimeOrg:mainfrom
vkareh:face-digital-weather

Conversation

@vkareh

@vkareh vkareh commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

If weather is available, display the cloud icon and temperature.

Screenshot at 2023-09-07 16-37-56

@github-actions

github-actions Bot commented Sep 7, 2023

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 373092B 464B
data 940B 0B
bss 63516B 0B

@vkareh
vkareh force-pushed the face-digital-weather branch from 5d4e321 to 82e7962 Compare October 25, 2023 17:51
@vkareh
vkareh force-pushed the face-digital-weather branch from 82e7962 to 200c8df Compare November 23, 2023 18:09
@vkareh
vkareh force-pushed the face-digital-weather branch from 200c8df to c15cc2a Compare December 1, 2023 16:21
@vkareh
vkareh force-pushed the face-digital-weather branch 2 times, most recently from f215dd0 to 78ddaa2 Compare January 4, 2024 14:55
@vkareh

vkareh commented Jan 4, 2024

Copy link
Copy Markdown
Contributor Author

Rebased against main and adapted to work with the SimpleWeatherService.

@FintasticMan FintasticMan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Comment thread src/displayapp/screens/WatchFaceDigital.cpp Outdated
@vkareh
vkareh force-pushed the face-digital-weather branch from 78ddaa2 to 5edb4e8 Compare January 4, 2024 17:44
@FintasticMan
FintasticMan requested a review from a team January 4, 2024 18:44
Comment thread src/displayapp/screens/WatchFaceDigital.cpp Outdated
Comment thread src/displayapp/screens/WatchFaceDigital.h
Comment thread src/displayapp/screens/WeatherSymbols.h Outdated
@vkareh
vkareh force-pushed the face-digital-weather branch 3 times, most recently from d024057 to 535bdda Compare January 15, 2024 13:59
@vkareh
vkareh force-pushed the face-digital-weather branch from 535bdda to bad760c Compare January 16, 2024 21:47
If weather is available, display the cloud icon and temperature.
@vkareh
vkareh force-pushed the face-digital-weather branch from bad760c to 19e0865 Compare January 23, 2024 14:46
@NeroBurner NeroBurner added this to the 1.15.0 milestone Jan 23, 2024

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FintasticMan
FintasticMan merged commit 2135e12 into InfiniTimeOrg:main Jan 23, 2024
@vkareh
vkareh deleted the face-digital-weather branch January 23, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants