Fix git hash calculation with Docker build - #1935
Conversation
|
Build size and comparison to main:
|
|
This is likely the cause for #1842. If possible I would prefer us to figure out why the ownership is dubious and fix that before just adding marking the source dir as safe. |
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
I think this is a valid fix for dev containers as described here: https://www.kenmuse.com/blog/avoiding-dubious-ownership-in-dev-containers/
Do you think we should block this PR until we figure that out, or can we merge it in the meantime? |
Fix error when compiling the Pinetime using the Docker image.
If done with Docker, the container does not trust the /sources
folder, leading to a blank response of the command that grabs
the git commit `git rev-parse --short HEAD`.
```
fatal: detected dubious ownership in repository at '/sources'
To add an exception for this directory, call:
git config --global --add safe.directory /sources
PROJECT_GIT_COMMIT_HASH_SUCCESS? 128
BUILD CONFIGURATION
-------------------
* Mode : Release
* Version : 1.3.0
* Toolchain : /opt/gcc-arm-none-eabi-10.3-2021.10
* GitRef(S) :
* NRF52 SDK : /opt/nRF5_SDK_15.3.0_59ac345
* Target device : PINETIME
* Build DFU (using adafruit-nrfutil) : Enabled
* Build resources : Enabled
```
If the `git config --global --add safe.directory /sources` is
added to the Dockerfile, the problem is solved and the hash is
added correctly.
c9761c9 to
46d6e35
Compare
FintasticMan
left a comment
FintasticMan
left a comment
There was a problem hiding this comment.
It's fine to merge it in the meantime. I've just updated this to the latest main.
4 participants
Fix error when compiling the Pinetime using the Docker image. If done with Docker, the container does not trust the /sources folder, leading to a blank response of the command that grabs the git commit
git rev-parse --short HEAD.If the
git config --global --add safe.directory /sourcesis added to the Dockerfile, the problem is solved and the hash is added correctly.Fixes #1842