Advertise HR service - #2088
Merged
Merged
Conversation
|
Build size and comparison to main:
|
|
Works for me too, I can now connect my PineTime as a HR sensor to my Garmin Edge Explore 2! Also using PineTime as a motion sensor with Sleep as Android still works, same as before. |
Member
Author
|
Forgot to mention, confirmed working with BLE gym equipment also |
JF002
approved these changes
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #897
The original problem was that an extra 128bit uuid was too big for the advertising packet
Works with OpenTracks (shows with the advertising filter on), NRF Connect shows both the DFU and HR service
Closes #895