Skip to content

fix: include quote slippage value in MixPanel event properties - #9786

Merged
micaelae merged 8 commits into
mainfrom
swaps4446-fix-post-submit-slippage
Aug 11, 2026
Merged

fix: include quote slippage value in MixPanel event properties#9786
micaelae merged 8 commits into
mainfrom
swaps4446-fix-post-submit-slippage

Conversation

@micaelae

@micaelae micaelae commented Aug 4, 2026

Copy link
Copy Markdown
Member

Explanation

Saves the QuoteResponse["quote"]["slippage"] value in the txHistory to populate the Submitted, Failed and Completed MixPanel events

References

Fixes https://consensyssoftware.atlassian.net/browse/SWAPS-4446

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Analytics-only fix on history field population; no change to submission or swap execution logic.

Overview
Bridge transaction history now records slippage from the submitted quote instead of always storing 0.

On SubmitStep.AddHistoryItem, slippagePercentage is set from quoteResponse.quote.slippage (with 0 when missing). That value is persisted on the history item so Unified SwapBridge Submitted, Failed, and Completed MixPanel events can report the correct slippage-related properties.

Tests and snapshots were updated to expect slippage: 0.01 on the quote and slippagePercentage: 0.01 on the history item.

Reviewed by Cursor Bugbot for commit a529ddb. Bugbot is set up for automated code reviews on this repo. Configure here.

@micaelae
micaelae marked this pull request as ready for review August 4, 2026 23:44
@micaelae
micaelae requested review from a team as code owners August 4, 2026 23:44
@micaelae
micaelae enabled auto-merge August 4, 2026 23:44
@micaelae
micaelae added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit 050719e Aug 11, 2026
46 checks passed
@micaelae
micaelae deleted the swaps4446-fix-post-submit-slippage branch August 11, 2026 16:40
@maxime-oe maxime-oe mentioned this pull request Aug 11, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants