fix(transaction-controller): Skip resimulation check when failing incomplete transactions at boot

[OGPoyraz]

Explanation

When TransactionController is constructed, #onBootCleanup() runs #failIncompleteTransactions() to transition any signed or approved transactions to failed. This calls #failTransaction(), which internally calls #updateTransactionInternal().

The problem is that #updateTransactionInternal() calls this.#isSimulationEnabled() for its resimulation check. In mobile, the isSimulationEnabled callback calls PreferencesController:getState via the messenger — but this is a controller initialization order problem: TransactionController is constructed inside Wallet during Engine.init, and at that point PreferencesController has not yet registered its action handler on the root messenger. The PreferencesController is a mobile-only controller that does not exist in the @metamask/wallet package, so the Wallet has no way to guarantee its availability during TransactionController construction.

This causes #failTransaction to throw, and the catch block creates a fallback TransactionMeta with status: failed but never writes it back to state. The transaction remains signed in persisted state permanently, surviving every app restart.

The fix adds skipResimulateCheck: true to the #updateTransactionInternal call inside #failTransaction. There is no reason to check whether a transaction needs resimulation when the intent is to mark it as failed.

References

• Discovered via MetaMask Mobile: a batch transaction on Arbitrum (0xa4b1) stuck in signed status indefinitely across app restarts

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Low Risk
Narrow change to the failure update path at boot with a targeted test; no API or simulation behavior changes for normal transaction flows.

Overview
Fixes startup cleanup so signed/approved transactions left over from a prior session are reliably marked failed instead of staying stuck in signed.

#failTransaction now passes skipResimulateCheck: true into #updateTransactionInternal, so boot-time failure no longer runs the resimulation path that calls isSimulationEnabled. That avoids throws when the callback depends on controllers (e.g. mobile PreferencesController) that are not registered yet during TransactionController construction—previously the error could prevent the failed status from being persisted.

Adds a regression test where isSimulationEnabled throws and both signed and approved txs still end up failed, plus an Unreleased changelog entry.

^{Reviewed by Cursor Bugbot for commit 0935188. Bugbot is set up for automated code reviews on this repo. Configure here.}