fix(network-connection-banner-controller): subscribe to ClientController:stateChange - #9893
Merged
cryptodev-2s merged 5 commits intoAug 17, 2026
Merged
Conversation
…ler:stateChange The controller subscribed to ClientController:stateChanged using a locally defined event type, but @metamask/client-controller only declares and exports ClientController:stateChange. Clients that delegate the exported event (mobile) never deliver UI open state, so the controller never starts and the banner never shows.
cryptodev-2s
temporarily deployed
to
default-branch
August 17, 2026 09:37 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Both clients delegate ClientController:stateChanged today and BaseController publishes both names, so the banner does work at runtime. The defect is the undeclared event type, not a dead subscription.
Contributor
Author
|
@metamaskbot publish-preview |
cryptodev-2s
enabled auto-merge
August 17, 2026 09:44
| this.messenger.subscribe( | ||
| 'ClientController:stateChanged', | ||
| // eslint-disable-next-line no-restricted-syntax -- awaiting upstream :stateChanged migration | ||
| 'ClientController:stateChange', |
Member
There was a problem hiding this comment.
Why is this necessary? Does ClientController not publish both?
Contributor
Author
There was a problem hiding this comment.
Because it's marked as deprecated.
Contributor
Author
There was a problem hiding this comment.
If remove it we get
Subscribing to ':stateChange' events is deprecated. Use ':stateChanged' instead.eslint[no-restricted-syntax](https://eslint.org/docs/latest/rules/no-restricted-syntax)
Member
There was a problem hiding this comment.
I wasn't referring to the eslint comment. I am curious why we are making this change in the first place and why we can't use :stateChanged in this controller? Is it not published by ClientController?
Contributor
Author
There was a problem hiding this comment.
No it's not defined by ClientController because it still uses :stateChange https://github.com/MetaMask/core/blob/main/packages/client-controller/src/ClientController.ts#L82
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
FrederikBolding
approved these changes
Aug 17, 2026
cryptodev-2s
deleted the
fix/banner-controller-client-state-change-event
branch
August 17, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
NetworkConnectionBannerControllersubscribes toClientController:stateChangedusing an event type it defines locally.@metamask/client-controlleronly declares and exportsClientController:stateChange.It works at runtime because
BaseControllerpublishes both names. This is a contract cleanup, not a behavior fix.Now the controller uses the exported
ClientControllerStateChangeEvent, dropping the duplicated local type and matching the three other upstream subscriptions in the file.Breaking: clients must delegate
ClientController:stateChangeinstead ofClientController:stateChanged, otherwise the controller stops receiving UI open state and the banner never shows. Both extension and mobile need the one line swap.References
Checklist
Note
Cursor Bugbot is generating a summary for commit ec8b9d7. Configure here.