feat: drop the CORS origin allow-list - #68
Merged
Conversation
The allow-list protected nothing. The API is public, read-only and
unauthenticated: no cookies, no Authorization header, nothing a browser could
be tricked into attaching to a cross-origin request. CORS is a browser-side
policy, so it never constrained an attacker anyway; curl and any server-side
client ignore it entirely. All it did was break the local frontend on :5173 and
every third-party tool pointed at the API.
The access control that does matter is unchanged and server-side: rate limiting
(100/min), query complexity limits, result-set caps, disabled mutations, and
restricted-branch filtering.
Removes the ALLOWED_ORIGINS env var and opens all three mounts (/graphql, /blob,
/events). Verified: preflight from four unrelated origins returns
Access-Control-Allow-Origin: *, no Access-Control-Allow-Credentials is emitted,
and a cross-origin POST returns {"data":{"branches":[]}}.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FNgjQ6o613ULuMRGhLnyUU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allow-list protected nothing. The API is public, read-only and
unauthenticated: no cookies, no Authorization header, nothing a browser could
be tricked into attaching to a cross-origin request. CORS is a browser-side
policy, so it never constrained an attacker anyway; curl and any server-side
client ignore it entirely. All it did was break the local frontend on :5173 and
every third-party tool pointed at the API.
The access control that does matter is unchanged and server-side: rate limiting
(100/min), query complexity limits, result-set caps, disabled mutations, and
restricted-branch filtering.
Removes the ALLOWED_ORIGINS env var and opens all three mounts (/graphql, /blob,
/events). Verified: preflight from four unrelated origins returns
Access-Control-Allow-Origin: *, no Access-Control-Allow-Credentials is emitted,
and a cross-origin POST returns {"data":{"branches":[]}}.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01FNgjQ6o613ULuMRGhLnyUU