Ps7 syntax - #1426
Merged
Merged
Conversation
Rob Holt (rjmholt)
requested review from
James Truher (JamesWTruher) and
Christoph Bergmeister (bergmeister)
and removed request for
Christoph Bergmeister (bergmeister)
March 11, 2020 20:41
Rob Holt (rjmholt)
force-pushed
the
ps7-syntax
branch
from
March 31, 2020 21:39
14ccfbe to
09d47c0
Compare
Rob Holt (rjmholt)
marked this pull request as ready for review
March 31, 2020 21:40
Christoph Bergmeister (bergmeister)
approved these changes
Mar 31, 2020
Christoph Bergmeister (bergmeister)
left a comment
Christoph Bergmeister (bergmeister)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM if the tests comes back green as well :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Waiting on #1425.Adds syntax checking for new PowerShell 7 syntaxes.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.