Make sure that tests results file gets uploaded in CI when there is a test failure - #1455
Merged
Christoph Bergmeister (bergmeister) merged 1 commit intoApr 20, 2020
Conversation
…, condition was not applied
Christoph Bergmeister (bergmeister)
requested review from
James Truher (JamesWTruher) and
Rob Holt (rjmholt)
April 20, 2020 18:24
Christoph Bergmeister (bergmeister)
changed the title
Christoph Bergmeister (bergmeister)
changed the title
Rob Holt (rjmholt)
approved these changes
Apr 20, 2020
James Truher (JamesWTruher)
approved these changes
Apr 20, 2020
James Truher (JamesWTruher)
left a comment
James Truher (JamesWTruher)
left a comment
Contributor
There was a problem hiding this comment.
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Due to too much indentation condition was not applied, I did test in another branch that in case there is a test failure, it actually works.
And that my friends is why I (don't) love yaml....
https://noyaml.com/
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.