Skip to content

Handle cases where the Signature generator fails catastrophically - #1661

Merged
Rob Holt (rjmholt) merged 9 commits into
PowerShell:masterfrom
JamesWTruher:collector001
Apr 21, 2021
Merged

Handle cases where the Signature generator fails catastrophically#1661
Rob Holt (rjmholt) merged 9 commits into
PowerShell:masterfrom
JamesWTruher:collector001

Conversation

@JamesWTruher

Copy link
Copy Markdown
Contributor

PR Summary

In the profile collector, there are some cases when we attempt to generate a method signature the framework will generate a platform not supported exception which causes the profile generation to fail.

We're not yet shipping the collector as a standalone module (as we think we may change it in the future), but we would like the functionality to work correctly.

PR Checklist

…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs

Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
@rjmholt
Rob Holt (rjmholt) merged commit 6e95790 into PowerShell:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants