Invoke-Formatter: Accept input from pipeline - #1763
Merged
James Truher (JamesWTruher) merged 3 commits intoAug 11, 2022
Merged
Conversation
Christoph Bergmeister (bergmeister)
changed the title
Contributor
|
LGTM Christoph Bergmeister (@bergmeister) :-) |
Collaborator
Author
|
Close and re-open so that Github removes the pending MacOs check which has been fixed/removed upstream in master |
Merged
6 tasks
| 'foo' | Invoke-Formatter | Should -Be 'foo' | ||
| } | ||
| It 'Value from Pipeline by Property Name with just the mandatory ScriptDefinition parameter' { | ||
| [pscustomobject]@{ 'ScriptDefinition' = 'foo' } | Invoke-Formatter | Should -Be 'foo' |
Contributor
There was a problem hiding this comment.
Suggested change
| [pscustomobject]@{ 'ScriptDefinition' = 'foo' } | Invoke-Formatter | Should -Be 'foo' | |
| [pscustomobject]@{ 'ScriptDefinition' = 'command1;command2' } | Invoke-Formatter | Should -Be 'command1; command2' |
James Truher (JamesWTruher)
approved these changes
Aug 11, 2022
James Truher (JamesWTruher)
left a comment
James Truher (JamesWTruher)
left a comment
Contributor
There was a problem hiding this comment.
this looks fine - just one suggestion below
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Implements #1761
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.