Skip to content

Do not print summary repeatedly for each logger - #2058

Merged
Andy Jordan (andyleejordan) merged 1 commit into
PowerShell:mainfrom
MatejKafka:summary-repeat
Feb 20, 2025
Merged

Do not print summary repeatedly for each logger#2058
Andy Jordan (andyleejordan) merged 1 commit into
PowerShell:mainfrom
MatejKafka:summary-repeat

Conversation

@MatejKafka

@MatejKafka Matěj Kafka (MatejKafka) commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

PR Summary

Updates the foreach loop where diagnostics are written to only write the summary once instead of once per logger. Given that the summary is always printed to the host (and not to the logger), it does not make sense to print it multiple times. Since there's only a single logger shipped with PSScriptAnalyzer, this does manifest in practice, but it's relevant for my follow-up PRs. :)

PR Checklist

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ran CI, looks good. Thoughts Andy Jordan (@andyleejordan) ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@andyleejordan
Andy Jordan (andyleejordan) merged commit 0fecc08 into PowerShell:main Feb 20, 2025
@MatejKafka
Matěj Kafka (MatejKafka) deleted the summary-repeat branch February 21, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants