Fix for PSUseConsistantWhiteSpace when using statement is present - #2091
Merged
Andy Jordan (andyleejordan) merged 6 commits intoApr 4, 2025
Merged
Conversation
AlexandraDorey-Magnet (AlexandraDorey)
requested review from
Andy Jordan (andyleejordan) and
Christoph Bergmeister (bergmeister)
as code owners
April 1, 2025 22:48
Contributor
Author
|
@microsoft-github-policy-service agree |
added 2 commits
April 1, 2025 19:53
Andy Jordan (andyleejordan)
approved these changes
Apr 1, 2025
Andy Jordan (andyleejordan)
left a comment
Andy Jordan (andyleejordan)
left a comment
Member
There was a problem hiding this comment.
Hey cool, good debugging. Read through your issue, I think you're right and this makes sense. Just approved the tests workflow.
AlexandraDorey-Magnet (AlexandraDorey)
changed the title
Christoph Bergmeister (bergmeister)
approved these changes
Apr 3, 2025
Christoph Bergmeister (bergmeister)
left a comment
Christoph Bergmeister (bergmeister)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, well done
Co-authored-by: Christoph Bergmeister <c.bergmeister@gmail.com>
Contributor
Author
|
Fixed the nits up, I'm not super familiar with github but I assume I can merge my commits into one commit when the PR merges or should I do that in by branch first? Otherwise should be good to merge once the tests run again :) |
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
April 4, 2025 00:51
Member
|
Sure can! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The addition of an using statement can cause the PSUseConsistant white space to fail due to how the InternalVisit of the UsingStatementAst is implemented in a slightly different way than other ASTs. See issue 2089 for more details.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.