Zarr Merger - #6633
Merged
Merged
Conversation
5 tasks
ericspod
reviewed
Jun 21, 2023
Member
|
We do also need tests to cover this code. Zarr does look interesting, I wonder if it would have other application MONAI, eg. data handling in transforms. |
JHancox
reviewed
Jun 21, 2023
JHancox
reviewed
Jun 21, 2023
JHancox
reviewed
Jun 22, 2023
JHancox
reviewed
Jun 22, 2023
bhashemian
enabled auto-merge (squash)
June 22, 2023 17:02
bhashemian
disabled auto-merge
June 22, 2023 17:02
dzenanz
reviewed
Jun 26, 2023
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
JHancox
approved these changes
Jun 26, 2023
Member
Author
|
Hi @ericspod, please take another look and let me know if you have any other comments. Thanks |
bhashemian
enabled auto-merge (squash)
June 27, 2023 19:45
wyli
reviewed
Jun 28, 2023
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Contributor
|
/build |
bhashemian
disabled auto-merge
June 28, 2023 13:59
bhashemian
enabled auto-merge (squash)
June 28, 2023 13:59
ericspod
approved these changes
Jun 28, 2023
ericspod
left a comment
ericspod
left a comment
Member
There was a problem hiding this comment.
Looks good, I had just very minor changes to docs.
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Dr. Behrooz Hashemian <3968947+drbeh@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Dr. Behrooz Hashemian <3968947+drbeh@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Dr. Behrooz Hashemian <3968947+drbeh@users.noreply.github.com>
JHancox
approved these changes
Jun 28, 2023
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
bhashemian
added a commit
to Project-MONAI/tutorials
that referenced
this pull request
Jul 4, 2023
This PR add an example for `ZarrAvgMerger` to be plugged into `PatchInferer` along with `WSISlidingWindowSplitter`. Note: Project-MONAI/MONAI#6633 in MONAI core should be merged before this one. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
This PR add an example for `ZarrAvgMerger` to be plugged into `PatchInferer` along with `WSISlidingWindowSplitter`. Note: Project-MONAI/MONAI#6633 in MONAI core should be merged before this one. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6006
Description
This PR implements
ZarrAvgMergerwhich can be used for patch inference. Also a use case is demonstrated here.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.