[WIP] 7145 common factory class - #7159
Merged
Merged
Conversation
ericspod
reviewed
Oct 24, 2023
ericspod
reviewed
Oct 24, 2023
ericspod
reviewed
Oct 24, 2023
wyli
reviewed
Oct 25, 2023
…nction only returns a single class
wyli
approved these changes
Oct 26, 2023
wyli
left a comment
wyli
left a comment
Contributor
There was a problem hiding this comment.
Thanks, the current logic looks good to me but please feel free to simplify them further..
Signed-off-by: Mark Graham <markgraham539@gmail.com>
I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: dfaa6a0 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 99ecb5a I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 8ebd0b6 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 81f1d88 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: d3669c7 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 393cdc6 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 7c8363d I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: bb9cf2a Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
…NAI into 7145_common_factory_class
marksgraham
marked this pull request as ready for review
October 27, 2023 12:46
Signed-off-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Contributor
|
/build |
ericspod
reviewed
Oct 27, 2023
ericspod
reviewed
Oct 27, 2023
ericspod
reviewed
Oct 27, 2023
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Mark Graham <markgraham539@gmail.com>
Contributor
|
/build |
wyli
enabled auto-merge (squash)
October 27, 2023 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.