Make MetaTensor optional printed in DataStats and DataStatsd #5905 - #7814
Merged
Conversation
Signed-off-by: Wei_Chuan, Chiang <jamesis1356@gmail.com>
for more information, see https://pre-commit.ci
slicepaste
changed the title
KumoLiu
reviewed
May 30, 2024
slicepaste
changed the title
Contributor
|
@slicepaste, after change the argument, please also try run Thanks! |
Contributor
Author
|
I'll figure out recently. Thanks for the reminder. |
Fixes Project-MONAI#7697 ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Fixes Project-MONAI#7646 ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Suraj Pai <b.pai@maastrichtuniversity.nl> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: Ben Murray <ben.murray@gmail.com>
slicepaste
force-pushed
the
fix-issue-5905
branch
from
June 3, 2024 08:40
64ae29a to
93bb3c6
Compare
Signed-off-by: Wei_Chuan, Chiang <jamesis1356@gmail.com>
Signed-off-by: Wei_Chuan, Chiang <jamesis1356@gmail.com>
slicepaste
force-pushed
the
fix-issue-5905
branch
from
June 3, 2024 08:48
93bb3c6 to
68b521b
Compare
Contributor
Author
|
@KumoLiu |
ericspod
reviewed
Jun 13, 2024
Contributor
|
Hi @slicepaste, do you plan to finish this PR? If we want to include the change in version 1.4, we only have about one or two weeks left to add new things. Thanks! |
Contributor
Author
|
Hi @KumoLiu , |
Signed-off-by: Wei_Chuan, Chiang <jamesis1356@gmail.com>
…into fix-issue-5905
Signed-off-by: Wei_Chuan, Chiang <jamesis1356@gmail.com>
Signed-off-by: Wei_Chuan, Chiang <jamesis1356@gmail.com>
KumoLiu
approved these changes
Aug 28, 2024
KumoLiu
left a comment
KumoLiu
left a comment
Contributor
There was a problem hiding this comment.
LGTM now, thanks for the quick update.
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5905
Description
We simply add one argument for DataStats and DataStatsd to make MetaTensor optional printed.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.