Fix Ruff Numpy2 deprecation rules - #8179
Merged
KumoLiu merged 3 commits intoOct 25, 2024
Merged
Conversation
Signed-off-by: James Butler <james.butler@revvity.com>
Signed-off-by: James Butler <james.butler@revvity.com>
See https://docs.astral.sh/ruff/rules/numpy2-deprecation/ Signed-off-by: James Butler <james.butler@revvity.com>
ericspod
approved these changes
Oct 24, 2024
ericspod
left a comment
ericspod
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution, this all looks fine to me.
Contributor
|
/build |
KumoLiu
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses expired numpy deprecations that happened with the numpy 2 release. This code is compatible with numpy 1 and 2 to support future enablement of numpy2 for monai.
See https://docs.astral.sh/ruff/rules/numpy2-deprecation/
Types of changes