Skip to content

bug: Fix PatchMerging duplicate merging - #8285

Merged
ericspod merged 2 commits into
Project-MONAI:devfrom
pooya-mohammadi:dev
Jan 10, 2025
Merged

bug: Fix PatchMerging duplicate merging#8285
ericspod merged 2 commits into
Project-MONAI:devfrom
pooya-mohammadi:dev

Conversation

@pooya-mohammadi

Copy link
Copy Markdown
Contributor

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Fixing issue #8284
In this format there are no duplicates:

t = [
    (0, 0, 0),
    (1, 0, 0),
    (0, 1, 0),
    (0, 0, 1),
    (1, 0, 1),
    (1, 1, 0),
    (0, 1, 1),
    (1, 1, 1),
    ]
print(set(t))
# {(1, 0, 1), (1, 1, 0), (0, 1, 0), (0, 0, 0), (1, 0, 0), (0, 0, 1), (1, 1, 1), (0, 1, 1)}

@KumoLiu KumoLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM.
Please sighoff to address the DCO issue. Thanks.
https://github.com/Project-MONAI/MONAI/pull/8285/checks?check_run_id=35266268085

@KumoLiu
KumoLiu requested review from Nic-Ma and ericspod January 9, 2025 08:13
….com>

I, pooya-mohammadi <pooyamohammadikazaj@gmail.com>, hereby add my Signed-off-by to this commit: 94195a9

Signed-off-by: pooya-mohammadi <pooyamohammadikazaj@gmail.com>
@KumoLiu

KumoLiu commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

/build

@ericspod
ericspod merged commit 1c00ea2 into Project-MONAI:dev Jan 10, 2025
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request Mar 10, 2025
Fixes # .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

Fixing issue Project-MONAI#8284
In this format there are no duplicates:

```
t = [
    (0, 0, 0),
    (1, 0, 0),
    (0, 1, 0),
    (0, 0, 1),
    (1, 0, 1),
    (1, 1, 0),
    (0, 1, 1),
    (1, 1, 1),
    ]
print(set(t))
# {(1, 0, 1), (1, 1, 0), (0, 1, 0), (0, 0, 0), (1, 0, 0), (0, 0, 1), (1, 1, 1), (0, 1, 1)}
```

---------

Signed-off-by: pooya-mohammadi <pooyamohammadikazaj@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants