Add oEmbed optimizer module - #886
Conversation
sgomes
left a comment
There was a problem hiding this comment.
Thank you for the PR, @adamsilverstein! I think this has the potential for some great wins! 👍
I left some non-blocking comments for your consideration. I'm not sure if I'll have the opportunity to re-review because of some upcoming AFK, so please feel free to move ahead at your discretion!
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
|
Thanks for all the feedback and suggestions @westonruter and @mukeshpanchal27! I'm going to work on adding tests. |
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
|
Two things:
Perhaps what should be done is to create a new |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Weston Ruter <westonruter@google.com>
That sounds good to me! |
|
I created the |
Thanks @westonruter - changed base branch |
Summary
Full issue - #888
Attempts to optimize oEmbeds using two techniques:
loading=lazyattribute is presentsrcbefore the user scrolls to the oEmbedRelated: https://core.trac.wordpress.org/ticket/58773
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.