Move auto-sizes to plugins folder - #972
Conversation
Co-authored-by: Pascal Birchler <pascalb@google.com>
Introduce plugins folder for standalone plugins
Merge trunk into feature/modules-to-plugins
…ance into add/plugins-test-suite
Merge trunk into feature/modules-to-plugins
Add test suite for Plugins folder
|
Once #975 is merged, we need to rebase this PR. |
|
@swissspidy @joemcgill @westonruter Could you please take another look when you have a moment? |
|
@joemcgill @westonruter Could you please take another look when you have a moment? |
| wp: 'trunk' | ||
| env: | ||
| WP_ENV_PHP_VERSION: ${{ matrix.php }} | ||
| WP_ENV_CORE: ${{ matrix.wp == 'trunk' && 'WordPress/WordPress' || format( 'https://wordpress.org/wordpress-{0}.zip', matrix.wp ) }} |
There was a problem hiding this comment.
Question: Why not use ternary expression here? Is it allowed?
| WP_ENV_CORE: ${{ matrix.wp == 'trunk' && 'WordPress/WordPress' || format( 'https://wordpress.org/wordpress-{0}.zip', matrix.wp ) }} | |
| WP_ENV_CORE: ${{ matrix.wp == 'trunk' ? 'WordPress/WordPress' : format( 'https://wordpress.org/wordpress-{0}.zip', matrix.wp ) }} |
There was a problem hiding this comment.
This was added as part of #544. If we need to update this, then we also have to update similar settings for other workflows (php-test.yml and php-test-standalone-plugins.yml).
Shall we open a follow-up PR to make these changes?
There was a problem hiding this comment.
Follow-up PR is fine. Just seems hard to read right now.
There was a problem hiding this comment.
@westonruter, GitHub workflow does not allow ${{ x ? 'ifTrue' : 'ifFalse' }} ternary operator. Instead, it uses ${{ x && 'ifTrue' || 'ifFalse' }}. Therefore, we don't need to open a follow-up PR for this work.
5 participants
Summary
Follow-up work #654 (comment)
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.