Extract repeated directory-check assertions into check-dir.sh helper

[brunoborges]

What

e2e-cache.yml repeated the same inline shell block many times to assert that a cache directory exists (and then ls it), plus several inverse checks (the gradle2/maven2/sbt2 cache-miss jobs) asserting a directory does not exist.

This PR deduplicates that logic into a single helper script.

Rebased onto main after #1124 merged, which consolidated e2e-cache-dependency-path.yml into e2e-cache.yml and added maven/sbt cache-dependency-path coverage. The extraction is now applied across all 25 checks in the consolidated workflow; the standalone dependency-path file no longer exists.

Changes

• New __tests__/check-dir.sh (POSIX sh, marked executable):
  • check-dir.sh <dir> [present|absent], default mode present.
  • present: fail with ::error::The <dir> directory does not exist unexpectedly + exit 1 when the directory is missing; otherwise ls it.
  • absent: fail with ::error::The <dir> directory exists unexpectedly + exit 1 when the directory exists.
• e2e-cache.yml now calls the helper instead of inline if [ ! -d ... ] blocks, keeping the exact same directories and present/absent semantics. Steps that only did check-and-ls collapse to a single line.
• Paths are passed already-expanded via $HOME (e.g. bash __tests__/check-dir.sh "$HOME/.gradle/caches") to avoid tilde-expansion pitfalls. The sbt jobs use a working-directory override, so they reference the script via $GITHUB_WORKSPACE.
• All if: OS conditionals are preserved (Coursier: ~/Library/Caches/Coursier on macOS, ~/AppData/Local/Coursier/Cache on Windows, ~/.cache/coursier on Ubuntu). The mvn/gradle/sbt build steps are unchanged.

Validation

• e2e-cache.yml parses via python3 + yaml.safe_load.
• bash -n __tests__/check-dir.sh passes.
• Functional smoke test confirms present/absent pass and fail (exit 1) as expected.

[Copilot]

Pull request overview

This PR deduplicates repeated “assert cache directory present/absent” shell logic in the cache E2E GitHub Actions workflows by introducing a shared __tests__/check-dir.sh helper and updating the workflows to call it.

Changes:

• Added __tests__/check-dir.sh to validate a directory is present (and ls it) or absent (and fail if it exists).
• Updated .github/workflows/e2e-cache.yml to replace repeated inline if [ -d ... ] assertions with calls to the helper.
• Updated .github/workflows/e2e-cache-dependency-path.yml to use the helper for the same directory assertions, including the one “absent” check.

Show a summary per file

File	Description
.github/workflows/e2e-cache.yml	Replaces repeated inline directory checks with calls to __tests__/check-dir.sh across gradle/maven/sbt jobs.
.github/workflows/e2e-cache-dependency-path.yml	Switches gradle cache dependency-path assertions to use the shared directory-check helper.
tests/check-dir.sh	New reusable script implementing present/absent directory assertions for workflow reuse.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 3
• Review effort level: Low