FINERACT-1932: Fineract modularization - fineract-loan - #3914
Merged
adamsaghy merged 1 commit intoJun 10, 2024
Conversation
alberto-art3ch
force-pushed
the
modularization/fineract-loan-v2
branch
from
June 1, 2024 23:45
4c6add2 to
2f9da98
Compare
ruchiD
reviewed
Jun 3, 2024
ruchiD
left a comment
ruchiD
left a comment
Contributor
There was a problem hiding this comment.
LGTM, Please check if we need to update persistence.xml of all the modules that depend on fineract-loan , with the domain entities that are now moved to fineract-loan.
alberto-art3ch
force-pushed
the
modularization/fineract-loan-v2
branch
from
June 4, 2024 17:12
2f9da98 to
3b32e47
Compare
Contributor
Author
Done! persistence.xml files updated. BTW I'm seeing some enum type classes in the peristence.xml file that I think must be not there |
alberto-art3ch
force-pushed
the
modularization/fineract-loan-v2
branch
2 times, most recently
from
June 5, 2024 00:29
6f647ec to
8f89d4b
Compare
alberto-art3ch
force-pushed
the
modularization/fineract-loan-v2
branch
from
June 6, 2024 21:48
8f89d4b to
c5a6d83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to fineract-loan module - used as Loan domain module classes, interfaces and services
FINERACT-1932
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.