Fineract-2091: Support for string type primary keys - part 1 - generic Auditable interface - #3922
Merged
Merged
Conversation
Contributor
|
@marta-jankovics do you mind explaining why this is needed? The JIRA ticket referenced is literally empty and the changeset is huge. Also, I see an unrelated commit, pls clean that up and keep the changeset to a minimal. |
marta-jankovics
force-pushed
the
FINERACT-2091
branch
from
June 10, 2024 13:51
d1fed55 to
1a1126d
Compare
marta-jankovics
changed the title
marta-jankovics
force-pushed
the
FINERACT-2091
branch
from
June 10, 2024 14:54
1a1126d to
d19e684
Compare
Contributor
Author
|
@galovics please see the description on the ticket https://issues.apache.org/jira/browse/FINERACT-2091 |
marta-jankovics
force-pushed
the
FINERACT-2091
branch
from
June 13, 2024 01:14
d19e684 to
5b2272c
Compare
marta-jankovics
force-pushed
the
FINERACT-2091
branch
from
June 13, 2024 11:34
5b2272c to
cefc585
Compare
marta-jankovics
force-pushed
the
FINERACT-2091
branch
from
June 13, 2024 16:18
cefc585 to
9f3a58f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.