FINERACT-2156: Confirm existance of elements before accessing them - #4202
Merged
Conversation
adamsaghy
reviewed
Dec 30, 2024
| @@ -0,0 +1,1068 @@ | |||
| # | |||
adamsaghy
reviewed
Dec 30, 2024
| @@ -0,0 +1,1093 @@ | |||
| # | |||
adamsaghy
requested changes
Dec 30, 2024
adamsaghy
left a comment
adamsaghy
left a comment
Contributor
There was a problem hiding this comment.
Please kindly remove the log files!
wkigenyi
force-pushed
the
2156
branch
2 times, most recently
from
December 30, 2024 21:52
d1052ab to
07b94e7
Compare
wkigenyi
marked this pull request as ready for review
December 31, 2024 06:58
Contributor
Author
|
@adamsaghy this is now ready for review |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Contributor
|
@wkigenyi any plans to continue this PR? |
Contributor
Author
|
Yes I work on it. Been busy with some back log. |
Contributor
Author
|
Hello Victor,
I will make effort to close it within the week.
Regards.
Wilfred
…On Mon, Mar 3, 2025 at 6:32 AM Víctor Romero ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java
<#4202 (comment)>:
> @@ -1594,12 +1594,19 @@ public void validateAccountBalanceDoesNotBecomeNegative(final String transaction
public void validateAccountBalanceDoesNotViolateOverdraft(final List<SavingsAccountTransaction> savingsAccountTransaction,
final BigDecimal amountPaid) {
if (savingsAccountTransaction != null) {
- SavingsAccountTransaction savingsAccountTransactionFirst = savingsAccountTransaction.get(0);
@wkigenyi <https://github.com/wkigenyi> Are you still working on the
ticket?
—
Reply to this email directly, view it on GitHub
<#4202 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEK6IQ7NAS5GE6GD2VGNAX32SPELLAVCNFSM6AAAAABS2DOJRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNJSHE4DONBZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
wkigenyi
force-pushed
the
2156
branch
3 times, most recently
from
March 10, 2025 16:38
2589c4d to
25a5d52
Compare
Contributor
Author
|
@adamsaghy could you guide me on how to fix this test? The result says it got status 403 instead of the 400 that was expected. In the test I specified: I am not sure that status code is being considered instead of the string I specified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.