FINERACT-2148: Accrual handling in case of Charged-off loan - #4350
Merged
adamsaghy merged 1 commit intoMar 3, 2025
Merged
Conversation
adamsaghy
reviewed
Feb 19, 2025
| } | ||
| } | ||
|
|
||
| private BigDecimal getInterestTillChargeOffForPeriod(final Loan loan, final LocalDate chargeOffDate) { |
Contributor
There was a problem hiding this comment.
This seems not correct for progressive loans...
adamsaghy
reviewed
Feb 19, 2025
| loanTransactionValidator.validateLoanRescheduleDate(loan); | ||
| } | ||
|
|
||
| private void createMissingAccrualTransactionIfNeeded(final BigDecimal newInterest, final Loan loan, final LocalDate chargeOffDate) { |
Contributor
There was a problem hiding this comment.
Would it make sense to move this into the LoanAccrualProcessingService?
Contributor
Author
There was a problem hiding this comment.
I considered moving this logic into the LoanAccrualProcessingService, but unfortunately, it wasn't feasible. Doing so introduces a circular dependency issue, making it impossible to use the service within the AdvancedPaymentScheduleTransactionProcessor. Therefore, I decided to move it in the AdvancedPaymentScheduleTransactionProcessor.
adamsaghy
reviewed
Feb 19, 2025
| final List<Long> existingReversedTransactionIds = loan.findExistingReversedTransactionIds(); | ||
|
|
||
| final LoanChargeOffBehaviour chargeOffBehaviour = loan.getLoanProductRelatedDetail().getChargeOffBehaviour(); | ||
| if (loan.isProgressiveSchedule()) { |
Contributor
There was a problem hiding this comment.
This should not be created only for progressive loans... We can create the missing accrual for cumulative loans as well...
mariiaKraievska
force-pushed
the
FINERACT-2333/accrual-handling-in-case-of-charged-off-loan
branch
from
February 24, 2025 10:07
1e3b80d to
9342585
Compare
Contributor
Author
|
PTAL |
mariiaKraievska
force-pushed
the
FINERACT-2333/accrual-handling-in-case-of-charged-off-loan
branch
2 times, most recently
from
February 24, 2025 10:56
b3d8a39 to
fe5e6d6
Compare
mariiaKraievska
force-pushed
the
FINERACT-2333/accrual-handling-in-case-of-charged-off-loan
branch
from
February 24, 2025 15:13
fe5e6d6 to
73eabd2
Compare
Contributor
Author
|
Please, consider this PR as a draft, because there are no tests from qa yet. |
adamsaghy
marked this pull request as draft
February 25, 2025 16:05
mariiaKraievska
force-pushed
the
FINERACT-2333/accrual-handling-in-case-of-charged-off-loan
branch
4 times, most recently
from
February 27, 2025 15:04
f1931f6 to
1bf0f24
Compare
peter-kovacs-dpc
force-pushed
the
FINERACT-2333/accrual-handling-in-case-of-charged-off-loan
branch
from
February 28, 2025 08:48
1bf0f24 to
ab5ea03
Compare
adamsaghy
marked this pull request as ready for review
February 28, 2025 09:27
mariiaKraievska
force-pushed
the
FINERACT-2333/accrual-handling-in-case-of-charged-off-loan
branch
from
February 28, 2025 11:11
ab5ea03 to
28eb8c4
Compare
mariiaKraievska
force-pushed
the
FINERACT-2333/accrual-handling-in-case-of-charged-off-loan
branch
from
February 28, 2025 15:55
28eb8c4 to
9665028
Compare
adamsaghy
deleted the
FINERACT-2333/accrual-handling-in-case-of-charged-off-loan
branch
March 3, 2025 15:30
mariiaKraievska
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accrual handling in case of Charged-off loan
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.