FINERACT-2197: Introduce a new type of ACTUAL during calculation of days in year - #4411
Merged
Conversation
somasorosdpc
force-pushed
the
FINERACT-2197/Introduce-a-new-type-of-ACTUAL-during-calculation-of-days-in-year
branch
4 times, most recently
from
March 6, 2025 13:19
a5b4206 to
c67fe68
Compare
Contributor
|
@somasorosdpc Can you please rebase based on the latest develop branch please? |
adamsaghy
reviewed
Mar 10, 2025
adamsaghy
reviewed
Mar 10, 2025
somasorosdpc
force-pushed
the
FINERACT-2197/Introduce-a-new-type-of-ACTUAL-during-calculation-of-days-in-year
branch
6 times, most recently
from
March 12, 2025 11:14
16e98c1 to
31e714e
Compare
somasorosdpc
marked this pull request as ready for review
March 12, 2025 11:17
ruzeynalov
force-pushed
the
FINERACT-2197/Introduce-a-new-type-of-ACTUAL-during-calculation-of-days-in-year
branch
2 times, most recently
from
March 13, 2025 13:40
d7b2c59 to
7a7754a
Compare
ruzeynalov
force-pushed
the
FINERACT-2197/Introduce-a-new-type-of-ACTUAL-during-calculation-of-days-in-year
branch
from
March 14, 2025 08:26
7a7754a to
bb04fcf
Compare
adamsaghy
deleted the
FINERACT-2197/Introduce-a-new-type-of-ACTUAL-during-calculation-of-days-in-year
branch
March 14, 2025 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce new flag days_in_year_custom_strategy and calculations for values in case of Days In Years set to ACTUAL.
FULL_LEAP_YEAR: 366 days for full leap year. → This is the by default value!
FEB_29_PERIOD_ONLY: 366 days for period of February 29
Introduce new field for loan and loan product
Implement calculations in EMICalculator
With covering unittest for EMI Calculator
Check associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.