Skip to content

FINERACT-2181: Refactor UpdateTrialBalanceDetailsConfig injection instead of Autowired. - #4457

Merged
adamsaghy merged 1 commit into
apache:developfrom
a7med3del1973:injection-refactoring
Mar 19, 2025
Merged

FINERACT-2181: Refactor UpdateTrialBalanceDetailsConfig injection instead of Autowired.#4457
adamsaghy merged 1 commit into
apache:developfrom
a7med3del1973:injection-refactoring

Conversation

@a7med3del1973

@a7med3del1973 a7med3del1973 commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Description

  • Remove @Autowired annotations.
  • Added Lombok's @RequiredArgsConstructor.
  • Changed Field Modifiers to final.

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@a7med3del1973 a7med3del1973 changed the title FINERACT-2081: Refactor UpdateTrialBalanceDetailsConfig injection instead of Autowired. FINERACT-2181: Refactor UpdateTrialBalanceDetailsConfig injection instead of Autowired. Mar 12, 2025
@a7med3del1973
a7med3del1973 force-pushed the injection-refactoring branch from 5f90704 to 46d9f20 Compare March 12, 2025 22:57
@adamsaghy

Copy link
Copy Markdown
Contributor

@a7med3del1973 I think we have a great number of classes which are doing the same and can be reworked to be generic and similar. Would you mind to broaden the scope of this PR?

@a7med3del1973

Copy link
Copy Markdown
Contributor Author

@a7med3del1973 I think we have a great number of classes which are doing the same and can be reworked to be generic and similar. Would you mind to broaden the scope of this PR?

Good point, working on it.

@a7med3del1973
a7med3del1973 force-pushed the injection-refactoring branch from 46d9f20 to 44d39de Compare March 15, 2025 00:49
@adamsaghy
adamsaghy merged commit 9fe9933 into apache:develop Mar 19, 2025
@a7med3del1973
a7med3del1973 deleted the injection-refactoring branch March 19, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants