Skip to content

FINERACT-2169: Apply dto for external event config api; - #4460

Merged
adamsaghy merged 1 commit into
apache:developfrom
VictorPavfurious:FINERACT-2169/External_event_config
Mar 19, 2025
Merged

FINERACT-2169: Apply dto for external event config api;#4460
adamsaghy merged 1 commit into
apache:developfrom
VictorPavfurious:FINERACT-2169/External_event_config

Conversation

@VictorPavfurious

Copy link
Copy Markdown
Contributor

Description

  1. Replace string req/res to dto;
  2. Update swagger docs and clean up;

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@VictorPavfurious

VictorPavfurious commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

@adamsaghy , This is pr had success completed tests, but i have to change commit, because of i have started using my deprecated email here.. So, i going to fix it and then you can merge OR run again all checks.
Sorry for my mistake

@VictorPavfurious
VictorPavfurious force-pushed the FINERACT-2169/External_event_config branch from 26f501d to ee11ffa Compare March 17, 2025 15:33
@VictorPavfurious

Copy link
Copy Markdown
Contributor Author

Fixed commit.

@adamsaghy
adamsaghy merged commit 84c101a into apache:develop Mar 19, 2025
@VictorPavfurious
VictorPavfurious deleted the FINERACT-2169/External_event_config branch March 28, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants